Linus Torvalds Gently Criticizes Build-Slowing Testing Code Left in Linux 6.15-rc1 (phoronix.com) 25
"The big set of open-source graphics driver updates for Linux 6.15 have been merged," writes Phoronix, "but Linux creator Linus Torvalds isn't particularly happy with the pull request."
The new "hdrtest" code is for the Intel Xe kernel driver and is around trying to help ensure the Direct Rendering Manager header files are self-contained and pass kernel-doc tests — basic maintenance checks on the included DRM header files to ensure they are all in good shape.
But Torvalds accused the code of not only slowing down the full-kernel builds, but also leaving behind "random" files for dependencies "that then make the source tree nasty," reports Tom's Hardware: While Torvalds was disturbed by the code that was impacting the latest Linux kernel, beginning his post with a "Grr," he remained precise in his objections to it. "I did the pull, resolved the (trivial) conflicts, but I notice that this ended up containing the disgusting 'hdrtest' crap that (a) slows down the build because it's done for a regular allmodconfig build rather than be some simple thing that you guys can run as needed (b) also leaves random 'hdrtest' turds around in the include directories," he wrote.
Torvalds went on to state that he had previously complained about this issue, and inquired why the hdr testing is being done as a regular part of the build. Moreover, he highlighted that the resulting 'turds' were breaking filename completion. Torvalds underlined this point — and his disgust — by stating, "this thing needs to *die*." In a shot of advice to fellow Linux developers, Torvalds said, "If you want to do that hdrtest thing, do it as part of your *own* checks. Don't make everybody else see that disgusting thing...."
He then noted that he had decided to mark hdrtest as broken for now, to prevent its inclusion in regular builds.
As of Saturday, all of the DRM-Next code had made it into Linux 6.15 Git, notes Phoronix. "But Linus Torvalds is expecting all this 'hdrtest' mess to be cleaned up."
But Torvalds accused the code of not only slowing down the full-kernel builds, but also leaving behind "random" files for dependencies "that then make the source tree nasty," reports Tom's Hardware: While Torvalds was disturbed by the code that was impacting the latest Linux kernel, beginning his post with a "Grr," he remained precise in his objections to it. "I did the pull, resolved the (trivial) conflicts, but I notice that this ended up containing the disgusting 'hdrtest' crap that (a) slows down the build because it's done for a regular allmodconfig build rather than be some simple thing that you guys can run as needed (b) also leaves random 'hdrtest' turds around in the include directories," he wrote.
Torvalds went on to state that he had previously complained about this issue, and inquired why the hdr testing is being done as a regular part of the build. Moreover, he highlighted that the resulting 'turds' were breaking filename completion. Torvalds underlined this point — and his disgust — by stating, "this thing needs to *die*." In a shot of advice to fellow Linux developers, Torvalds said, "If you want to do that hdrtest thing, do it as part of your *own* checks. Don't make everybody else see that disgusting thing...."
He then noted that he had decided to mark hdrtest as broken for now, to prevent its inclusion in regular builds.
As of Saturday, all of the DRM-Next code had made it into Linux 6.15 Git, notes Phoronix. "But Linus Torvalds is expecting all this 'hdrtest' mess to be cleaned up."
Re: (Score:3)
A microkernel implementation (Score:5, Funny)
They will rewrite the Linux kernel from scratch within months!
Awesome, looking forward to a microkernel implementation. :-)
Re: (Score:2)
in COBOL!
Re: (Score:2)
For this to work we have to rewrite Linux in COBOL, so that DOGE can rewrite in months for us. Hopefully as a Python service wrapped in a container or Kubernetes pod, and fully RESTful with a Semantic versioning API.
Regression in 15 (Score:4, Interesting)
First, I like Phoronix and support Michael Larabel's many year effort.
Second, I like Linux and he speaks to truth which as a coder I appreciate.
I always run the latest release kernel, and sometimes the RC-5/6 branch.
This time I waited til 15. Sadly I also added a second monitor.
DRM is just a bear. It took several "set as primary monitor" "change resolution"
and "hard reboot" (soft would hang) to get things to were I could down downres the
max hardres the primary (laptop Dell 7xxx) and keep the backup (HP 24" HDMI)
without "windows" crossing "displays". Sorry for the quotes, but it's getting so the
terminology is not keeping up with what shows up on the monitors. I'd even say
"displays on the monitors" but "displays" means something too.
NOT a complaint. NOT a whine. I know what's involved and the devs are doing great.
And yes, Linus is not wrong. This needs a little bit of a whoa-horsey pullback and fixing
things. Some of those things are not part of a test suite because there are so many variables
and so much subjective interaction.
Again, I support Phorotnix and Michael and will continue to do so.
I agree with Linus.
I back the devs as I can.
The product WILL get better. I can't wait.
Ehud
Tucson Arizona USA (that country currently fucking itself in the world, ugh)
Re: (Score:2)
Is having two displays with different DPI numbers still a hassle? My secondary screen is 4k tv for watching media.
Re: (Score:2)
Good (Score:5, Insightful)
Looks like he's a responsible maintainer who questions and controls tech debt before it becomes a serious issue. Many people could learn from that.
Re: (Score:2)
So the gently part (Score:3)
Gentle? (Score:3)
I presume he got kidnapped and is trying to discretely attract attention.
I see no other rational explanation for "Linus Torvalds" and "gently" occurring in the same sentence, perkele!
Re: (Score:2)
Yes, only uttering "crap" and "turd". From Linus, this is indeed gentle.
Don't know about you, man (Score:2)
But to make your code stand out above the rest -- or should I say, under everybody's shoe -- won't be worth bragging points at the bar
Slow news day? (Score:2)
Why is this news? Something writes a pull request and their test routine isn't deemed to be clean code, so the pull request gets not accepted yet. This happens in thousands of projects every day. It's not like Linus fired the developer or something.
Re: (Score:2)
Which is part of the point. Software developers are lazy. Rather than write neat, clean-as-can-be code, they throw the pot of spaghetti, sauce and all, at the wall and call it a day. When you have terabyte drives and gigs of RAM, what does it matter if your code is bloated and makes the system run through extraneous hoops?
Whenever we do video driver updates on our laptops before sending them out we ask the question: why does an onboard video card need a 600 MB, or more, driver update when all it's doing
Re: (Score:2)
Well, he didn't throw anything (Score:5, Funny)
Linus Torvalds Gently Criticizes
That'll be the day.
So... (Score:3)
building is not testing.... (Score:2)
Re: (Score:1)
Mandatory testing during all builds . . . (Score:1)
. . . is bogus. It slows down the iterative develop-build process FAR too much - even for most realistically helpful “unit tests”. It’s MUCH better to simply make such testing optional, and require it before merge into a broadly shared branch (especially the main code base).
And I fully agree with Linus that testing shouldn’t pollute the code tree with random artifacts. The output should go into a separate, easily deleted, directory (preferably under /tmp on UNIX in order to harvest t