Want to read Slashdot from your mobile device? Point it at m.slashdot.org and keep reading!

 



Forgot your password?
typodupeerror
Linux

Linus Torvalds Rejects RISC-V Changes For Linux 6.17 For Being Late and 'Garbage' (phoronix.com) 173

"Linus Torvalds has used his authority to reject the RISC-V architecture changes for the Linux 6.17 kernel," reports Phoronix: Only on Friday were the RISC-V code updates submitted for the Linux 6.17 merge window. The Linux 6.17 merge window is expected to wrap up on Sunday with the Linux 6.17-rc1 release... [T]his pull request has been rejected by Linus Torvalds for Linux 6.17 on the basis of being late in the merge window especially with his international travels this week being known. And he's unhappy with some of the code included as part of this merge request. .
Here's the text of Torvalds' response...


> RISC-V Patches for the 6.17 Merge Window, Part 1

No. This is garbage and it came in too late. I asked for early pull requests because I'm traveling, and if you can't follow that rule, at least make the pull requests *good*.

This adds various garbage that isn't RISC-V specific to generic header files.

And by "garbage" I really mean it. This is stuff that nobody should ever send me, never mind late in a merge window.

Like this crazy and pointless make_u32_from_two_u16() "helper".

That thing makes the world actively a worse place to live. It's useless garbage that makes any user incomprehensible, and actively *WORSE* than not using that stupid "helper".

If you write the code out as "(a
In contrast, if you write make_u32_from_two_u16(a,b) you have not a f%^5ing clue what the word order is. IOW, you just made things *WORSE*, and you added that "helper" to a generic non-RISC-V file where people are apparently supposed to use it to make *other* code worse too.

So no. Things like this need to get bent. It does not go into generic header files, and it damn well does not happen late in the merge window.

You're on notice: no more late pull requests, and no more garbage outside the RISC-V tree.

Now, I would *hope* there's no garbage inside the RISC-V parts, but that's your choice. But things in generic headers do not get polluted by crazy stuff. And sending a big pull request the day before the merge window closes in the hope that I'm too busy to care is not a winning strategy.

So you get to try again in 6.18. EARLY in the that merge window. And without the garbage.



Torvalds' message drew a conciliatory response from the submitter of the patches. "I'll stop being late, and hopefully that helps with the quality issues."

Linus Torvalds Rejects RISC-V Changes For Linux 6.17 For Being Late and 'Garbage'

Comments Filter:
  • by VaccinesCauseAdults ( 7114361 ) on Saturday August 09, 2025 @06:51PM (#65578304)
    Sounds like everything is on schedule for desktop dominance by the year 2140.
    • by Valgrus Thunderaxe ( 8769977 ) on Saturday August 09, 2025 @07:05PM (#65578324)
      It's been on my desktop since 1997.
      • by ksw_92 ( 5249207 ) on Saturday August 09, 2025 @07:14PM (#65578342)

        With WSL2, it's on my Windows 11 desktop and has been for a few years, working side-by-side. I get the steak AND the salad.

        • With WSL2, it's on my Windows 11 desktop and has been for a few years, working side-by-side. I get the steak AND the salad.

          Same here. And I've been doing BYO PCs and dual booting since the mid 1990s. With my carefully selected parts both Windows and Linux have been running flawlessly for decades.

          And I'm getting a jump start on ARM Linux (Debian) via Parallels on an ARM based Mac.

      • by cruff ( 171569 )

        It's been on my desktop since 1997.

        Gotcha beat. Had a DEC Alpha AXPpci 33 running Linux in 1994. Installed from 30 or so floppies.

        • by 93 Escort Wagon ( 326346 ) on Saturday August 09, 2025 @08:47PM (#65578498)

          30 floppies in the mid-1990s... are you sure you're not remembering Windows 95, grandpa?

          • Did a floppy install in '94 too. CD-Rom support was sketchy back then. On PCs it was all proprietary interfaces, no IDE standard.

            • by bobby ( 109046 )

              I barely knew about them at the time and was unhappy when I learned about the many. Company I worked for at that time was doing all SCSI hard disks and CD drives. I got lucky and got an external NEC CD drive (on clearance) that has SCSI and it worked very well. Also got early Linux CDs including SLS, Yggdrasil, and I forget what else. I tried several, liked SLS which became Slackware, which is still my primary Linux distro. I used to boot from a pair of floppies, but fortunately never had to install from a

            • by bobby ( 109046 )

              Yeah I just remembered- the CD drive often (usually?) connected to a sound card. They often were sold together. IIRC some sound cards had 2 or 3 CD drive interface connectors, so could support most drives. Ugh.

          • by ufgrat ( 6245202 )

            I was installing FreeBSD from two floppies and a network connection. 30 floppies is tragic.

            • by ls671 ( 1122017 )

              I was installing FreeBSD from two floppies and a network connection. 30 floppies is tragic.

              It was faster to use 30 floppies if you had to install on several computers or wanted/needed to re-install many times. Downloading everything over dialup every time was tragic. You could put the 30 floppies content on a local NFS server for even faster installs although if that's what you meant although.

          • Windows 95 didn't have that many floppies.

            Office 95 on the other hand...

          • 30 floppies in the mid-1990s... are you sure you're not remembering Windows 95, grandpa?

            By mid 90s both Linux and Windows 95/NT had CD-ROM. Last floppy based install for me was DOS and Windows 3.1.

        • by Wizy ( 38347 )

          Why'd ya wait so long, a solid year behind the early adopters.

        • by drnb ( 2434720 )

          It's been on my desktop since 1997.

          Gotcha beat. Had a DEC Alpha AXPpci 33 running Linux in 1994. Installed from 30 or so floppies.

          I think by '94 I brought home Linux and FreeBSD CD-ROMs from the local computer swap meet.

      • It's been on my desktop since 1997.

        Dual booting since 486DX2 days, '94ish.

        Now running Intel based Debian Linux on the Windows desktop via Windows Subsystem for Linux and ARM based Debian on the Mac desktop using Parallels. And embedded Linux on SBC.

        • by CptJeanLuc ( 1889586 ) on Sunday August 10, 2025 @04:48AM (#65579040)

          Taking a trip down this particular memory lane always makes me happy. Started university science/tech studies in 94. The diverse types of networked Unix machines on campus was a whole new world opening up. Spent many nights on campus in front of an SGI Indy computer. Joined the nerdiest student organization. Not a lot of love for Microsoft in that group. Interesting group of people who would help rookies get going in the right direction - but get to the point where you should get self going, and answers to questions turned into the simple phrase "man man".

          Installed Slackware from floppies in late 94 or early 95 on my 486DX 33MHz. Had to get a new compatible video card. Remember my fear during installation of setting the infamous dot clock frequency, with the supposed risk of frying your monitor.

          The next year moved into campus organized housing with 10 Mbps Ethernet. Such happy times! At some point after Linux got SMP support, I got myself a Tyan Tomcat dual processor motherboard with two pentium processors. You could compile the experimental 1.3.x linux kernels - and encode MP3 files - twice as fast! Nice for experimenting with parallell algorithms and related programming frameworks.

    • by HiThere ( 15173 ) <(ten.knilhtrae) (ta) (nsxihselrahc)> on Saturday August 09, 2025 @07:13PM (#65578340)

      I don't consider that a "kind and gentle" response, but if he described the code accurately, it does seem warranted.

      • I have a kind of mindset when deep in coding for weeks, I don't tolerate any BS and I get terse. I forget to be polite, and almost forget that it is humans that I am talking to. I'm guessing he had a moment like that.
      • by sjames ( 1099 )

        No F bombs, no anatomical suggestions. Unlikely to leave nothing but a smoking pair of shoes if said in person...

    • What, One of the few O/S'es you can have on RISC-V is linux. Windows not so much.
    • by Mr. Dollar Ton ( 5495648 ) on Saturday August 09, 2025 @08:31PM (#65578480)

      Sounds like everything is fine, since the other side has responded and the response is.


      OK, sorry. I've been dropping the ball lately and it kind of piled up
      as taking a bunch of stuff late, but that just leads to me making
      mistakes. So I'll stop being late, and hopefully that helps with the
      quality issues

      That is, the content of the Linus comment is acknowledged, people have planned to rectify the issues, there are apparently not hurt feelings and the RISC-V community and everyone else will get a safer update one cycle later.

      Shit happens sometimes even to the best, which may well have been the case here.

      What's not to your liking?

      • by ChunderDownunder ( 709234 ) on Saturday August 09, 2025 @08:54PM (#65578506)

        Phoronix posts some decent stuff but a lot of it is clickbait, trying to taint Linus as some sort of dictatorial sociopath. The kernel has survived more than three decades because its founder still gives a damn about code quality.

        A couple of dozen contributors, one big merge and the maintainer probably didn't write or review the helper function that Linus got annoyed about. This right before the release.

        Just because it compiles and 'works' doesn't mean you should ship it and as a maintainer, he'll do a more thorough job next time.

        • Yeah, I agree, it appears to be a thing blown out of all proportion that will be forgotten next week with the fortunate side effect of less bad code in the kernel.

      • >"What's not to your liking?"

        Can't speak for who you are replying to, but Linus' post was unnecessary long, repetitive, and hostile. He is right, of course, but that doesn't mean it needs to be so caustic.

        • Aw, come on, he's tamed a lot with age, you surely remember what it was like in the 90s and the early 00s...

          Seriously though, probably the reason for this minor tantrum is the frustration coming from him expecting these problems and warning against it, and then them appearing anyway.

          https://www.techspot.com/news/... [techspot.com]

          I haven't followed LKML closely for too many years to have an opinion if there is a better way to deal with code quailty problems reappearing in every new architecture. Given the track record, I'

        • It IS worth noting that he did not once insult the programmer, he kept his opinion strictly to the code and its lack of quality. That's a big (and meaningful) step! And honestly, it looks like it worked.

          It WAS garbage code. Even good programmers/people write bad code sometimes, and I'd rather someone tell me that the code is bad than not so I can fix it.

          • Yes! Criticisms of the code, actual specific concrete criticisms that you can fix are valuable. Vague criticisms and personal insults are not. The latter caused a number of good people to leave kernel dev. It looks like Linus has fixed his shit, and the former is a very different kettle of fish.

    • Sounds like everything is on schedule for desktop dominance by the year 2140.

      Nah, the "Year of the Linux Desktop" has already evolved into the "Year of Linux on the Microsoft Windows Desktop". The Windows Subsystem for Linux is diminishing the need for for dual booting, or a separate Linux box. Now we have games, commercial software, pretty much all the major FOSS apps which have downloadable Windows binaries, and Linux and all the toolchains that run under Linux (thinking embedded), etc ... all on the same convenient desktop.

    • by 2TecTom ( 311314 )

      Linux is the only safe desktop, windows isn't ours anymore, it's theirs and when you install windows 11 , they will own you too

    • Why should I switch to Linux from Windows ?
      Give me a reason that I care about, not a reason you care about
      You have been telling me , nonstop, for 25 years that OSS is good
      and you know what ? I don't care, and if I haven't changed my mind in 25 or so years, I"m not gonna change now

      let me repeat that I don't care about OSS and you are not gonna change my mind.

      My main use of office is to make graphs in excel. every 5 years or so, I download the latest open office thing, or libre thing, and give it a whirl, and

  • by Anonymous Coward on Saturday August 09, 2025 @07:51PM (#65578398)
    Mangled summary:

    If you write the code out as "(a
    In contrast, if you write make_u32_from_two_u16(a,b) you have not a f%^5ing clue what the word order is. IOW, you just made things *WORSE*, and you added that "helper" to a generic non-RISC-V file where people are apparently supposed to use it to make *other* code worse too.

    Apparently EditorDavid is new to Slashdot and doesn't know how to escape metacharacters. The actual text in TFA, quoting Linus:

    If you write the code out as "(a << 16) + b", you know what it does and which is the high word. Maybe you need to add a cast to make sure that 'b' doesn't have high bits that pollutes the end result, so maybe it's not going to be exactly _pretty_, but it's not going to be wrong and incomprehensible either.

    In contrast, if you write make_u32_from_two_u16(a,b) you have not a f%^5ing clue what the word order is. IOW, you just made things *WORSE*, and you added that "helper" to a generic non-RISC-V file where people are apparently supposed to use it to make *other* code worse too.

  • And it wins where it matters. Where waste of any type matters (Lean, Toyota). On servers, where the company cares and efficiency translates to income. Also on desktop, where the individual cares and efficiency translates to work satisfaction.
    • Where waste of any type matters (Lean, Toyota).

      Pity about Toyota's code, which we know to be trash after the code reviews (not NASA's worthless one, but the good one from the Barr Group) revealed that they not only don't follow industry best practices, they don't even follow their own documented guidelines.

      • by Jeremi ( 14640 )

        Pity about Toyota's code, which we know to be trash after the code reviews (not NASA's worthless one, but the good one from the Barr Group) revealed that they not only don't follow industry best practices, they don't even follow their own documented guidelines.

        That was true back then; is it still true now, a number of years, and many expensive lawsuit-settlements later? (I suppose it's possible that Toyota has learned nothing from the experience, but that doesn't seem like the most likely outcome from a company that generally prides itself on quality and reliability)

        • I'd bet there's been improvements, but I'd also bet there's still embarrassments.

          Can't be any worse than modern Bosch stuff :D

  • by bubblyceiling ( 7940768 ) on Sunday August 10, 2025 @03:45AM (#65578990)
    I like his no nonsense attitude. Glad that Linus doesn't hold back his punches and calls people out
    • I'm really surprised by the huge initial comment chain about how this dooms linux. My first response was to worry about when Linus is gone and there is no respected authority who can tend to quality in this manner. Elevating MBA concerns above code quality is how we get... most of the products out there.
  • An entire industry of YouTube based explainers will now proceed to interpret Linus's latest statements for the next two weeks.

"Even if you're on the right track, you'll get run over if you just sit there." -- Will Rogers

Working...