Stories
Slash Boxes
Comments

News for nerds, stuff that matters

Slashdot Log In

Log In

Create Account  |  Retrieve Password

e1000e Bug Squashed — Linux Kernel Patch Released

Posted by Soulskill on Fri Oct 03, 2008 09:01 PM
from the good-news-everyone dept.
ruphus13 writes "As mentioned earlier, there was a kernel bug in the alpha/beta version of the Linux kernel (up to 2.6.27 rc7), which was corrupting (and rendering useless) the EEPROM/NVM of adapters. Thankfully, a patch is now out that prevents writing to the EEPROM once the driver is loaded, and this follows a patch released by Intel earlier in the week. From the article: 'The Intel team is currently working on narrowing down the details of how and why these chipsets were affected. They also plan on releasing patches shortly to restore the EEPROM on any adapters that have been affected, via saved images using ethtool -e or from identical systems.' This is good news as we move towards a production release!"
+ -
story

Related Stories

[+] OpenSUSE Beta Can Brick Intel e1000e Network Cards 129 comments
An anonymous reader writes "Some Intel cards don't just not work with the new OpenSUSE beta, they can get bricked as well. Check your hardware before you install!" The only card mentioned as affected is the Intel e1000e, and it's not just OpenSUSE for which this card is a problem, according to this short article: "Bug reports for Fedora 9 and 10 and Linux Kernel 2.6.27rc1 match the symptoms reported by SUSE users."
This discussion has been archived. No new comments can be posted.
The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.
 Full
 Abbreviated
 Hidden
More
Loading... please wait.
  • News? (Score:3, Insightful)

    by quarrel (194077) on Friday October 03 2008, @09:06PM (#25253193)

    I know this is News For Nerds and all that, but isn't this a tad specific?

    An alpha/beta of the most recent linux kernel patch had a bug fixed, and it hits the front page?

    Don't get me wrong, I'm glad they found it, but this is kinda the point of debug cycles.. If we start reporting every bug squashed in all the major open source projects out there this is going to go downhill fast.. (of course, it's possible some may think that the idle. is only a step above..)

    --Q

    • (of course, it's possible some may think that the idle. is only a step above..)

      Or a step below...

    • Re:News? (Score:5, Insightful)

      by Atriqus (826899) on Friday October 03 2008, @09:25PM (#25253293) Homepage
      It's newsworthy because it was a bug that actually bricked hardware.
        • Re:News? (Score:5, Insightful)

          by sumdumass (711423) on Friday October 03 2008, @10:45PM (#25253653) Journal

          Try Erasing the BIOS on the main board and you will be more accurate in your comparison.

          This bug actually flashed the firmware for the network controller and hosed access to it in some unexplained sort of way. That is something note worthy because of the rarity of it. If it was simply hosing something that was readily diagnosable and more common like a boot sector or something, then it would be different. It isn't often the software is associated with hardware damage either purposefully or accidentally.

          BTW, I know there are recovery methods for a hosed BIOS. That isn't the point. Simply installing an operating system shouldn't hose it nor should it hose hardware either. Imagine all the people who just thought their card was broken or something and went for a refund under warranty or the bad name Intel or Linux received for the "faulty shipment of devices" or the ability to break a device. This is something that would work in windows, load Linux in a dual boot mode, it would stop working in both windows and Linux without any errors or indication that the car was even capable of being seen by the mainboard.

          • It was even more fun. Once the card was hosed, not only would it not work, but it required a bit of hacking to get it recognized enough to attempt a re-flash (assuming you had an image of the correct contents to flash in).

            The exact cause was mysterious as well since it didn't happen to everyone, nor was it predictable if or when it would happen.

        • I mean, who in their right mind would call a PC without an operating system bricked?

          Entirely too many people. Of course, "right mind" is subjective...

        • What, really "bricked" or just needing a reflash?

          Bricked but theoretically recoverable with some further work.

          The cards should be fixable by reflashing, but when you can't enumerate the card on the bus, that's a bit of a challenge.

        • No that is what is to be expected from an alpha, anything else means your just taking unnecessary risks. Alpha means the code has been developed and tested internally, NOT with your programs, NOT with your hardware, now if you run linus' or morton's machine then you will probably not come across this kind of bug but anybody else is running essentially untested code. While BSD claim they review their code, the fact that this bug wasn't caused by somebody commenting out #do not break drivers foo means that a

    • Re:News? (Score:5, Informative)

      by SL Baur (19540) <steve@xemacs.org> on Friday October 03 2008, @09:29PM (#25253317) Homepage Journal

      An alpha/beta of the most recent linux kernel patch had a bug fixed, and it hits the front page?

      They have not fixed the bug that caused the e1000e ethernet cards to get bricked. This is at least a two part bug. The EEPROM should not have been writable and Something Is Happening to cause bad writes to happen. What that "Something" is, no one knows yet, though it appears they are getting close.

      Linus is an absolute, total anal retentive with regards to fixing bugs by understanding and fixing the root cause[1], not just papering over it. This papers over it for the moment, because the bug hasn't been isolated yet, but it allows more people to participate because the side effects were really nasty - this was a true bricking of the ethernet card.

      This stage isn't newsworthy for Slashdot.[2] It must be a slow news day.

      [1] This is a Good Thing.

      [2] Nor will the real bug fix when it comes. A bug is found, a bug is fixed. Life, goes on.

    • Re:News? (Score:5, Interesting)

      I know this is News For Nerds and all that, but isn't this a tad specific?

      That's what sections are for. See the little Tux Icon over there? We all care about Linux. Besides, it's a VERY IMPORTANT BUG. A showstopper, so to speak. And keep in mind that a lot of people in here are kernel freaks. They want to test-drive the latest versions of the kernel. And one of the reasons why people keep coming here (and not to digg) is precisely for this kind of news.

      Thanks, ruphus13.

  • by kcbanner (929309) on Friday October 03 2008, @09:08PM (#25253213) Homepage Journal
    Hwwaa? Oh yes...the kernel does't corrupt your EEPROM anymore!
  • by Anonymous Coward on Friday October 03 2008, @09:14PM (#25253241)

    Linus isn't very happy with Intel here:
    http://lkml.org/lkml/2008/9/29/368

    On Mon, 29 Sep 2008, Arjan van de Ven wrote:
    >
    > we have a patch to save/restore now, in final testing stages
    > (obviously we want to be really careful with this)

    Btw, the _real_ bug is clearly in the hardware design that allows you to
    brick those things without apparently even having a lock bit.

    I'm hoping Intel doesn't treat this as just a software bug. Some hw
    designer should be thinking hard about which orifice they put their head
    up in.

    It used to be that you could fry some monitors by feeding them
    out-of-range signals. The _monitors_ got fixed.

                    Linus

    • by techno-vampire (666512) on Friday October 03 2008, @10:46PM (#25253659) Homepage
      He's got good reason. It should be impossible for the system to write to the EEPROM without special measures being taken, possibly a jumper that has to be removed to allow it. And, if possible, the card won't work right (in some way that doesn't prevent boot) until the jumper's put back to normal. That way, if you really have to re-flash it, you can, but it's not going to happen by accident.

      I remember having a motherboard with a jumper that had to be specially set to update the BIOS. The smart way was to power down, open the case and pull the jumper so that you could flash the EEPROM. Then, of course, once that was done, reverse the procedure for safety. I always regarded anybody who left the jumper off for the rare convenience as fools who deserved anything that might happen.

      • Re: (Score:3, Informative)

        Jumpers are not really used a lot these days. They cost extra, and are clumsy to handle (need to open case). You are right it would be really good if there were some precautions taken so no accidental writes happen (for instance need some special command sequence hard to trigger accidentally), but often those eeprom chips just have a simple serial interface, and reading and writing works almost exactly the same. A couple of years ago you could easily overwrite the eeprom of hauppauge tv cards (though there
      • Given the cost of EEPROM space, I think the better answer is to double the size. One half is readable, one writable, at any point in time. To update, you write, turn off, flip the jumper across to the other side (or, heck, just use a physical switch) and you're done. Bricking isn't absolutely impossible (you could write a damaged image to one half which wipes the other when it boots), but essentially infeasible.

      • Re: (Score:3, Informative)

        It is not uncommon to require a set of magic numbers to be written before writing to protected memory. The magic numbers and/or access pattern is designed so that no simple or likely hardware failure will allow unprotected access. Small discrete or integrated EEPROMs often have this functionality built in.

        • Well, I haven't needed to do a BIOS upgrade in this millennium, I think, and I only had one motherboard that needed a jumper change. As far as your comedy of errors goes, anybody who didn't plan ahead and make sure the update was already on the hard disk before starting deserves all the problems you described. And, of course, flashing the EEPROM on a NIC should be a rare event. Nice strawman, though.
          • Well, I haven't needed to do a BIOS upgrade in this millennium, I think

            Good for you...

            I know my keyboard has had its firmware upgraded at least once. I haven't had to do a BIOS update for awhile...

            I do remember a series of incremental improvements to the whole process:

            The very first time I flashed a BIOS, it was relatively easy -- just run the BIOS update program (in Windows), which formats a floppy for me, which I then boot off of. After booting the floppy, I still have to dump the BIOS, then load the new one -- from a DOS commandline.

            I streamlined the process a bit when CDs

          • And, of course, flashing the EEPROM on a NIC should be a rare event. Nice strawman, though.

            Doing any kind of firmware upgrade should be a rare event. At minimum it should involve first shutting down the driver accessing that piece of hardware. If the peripheral is designed sensibly an "upgrade firmware" command would require some kind of "handshake" and only be accepted as the first command after a reset.
        • possibly not even a reboot

          Unlikely. I would imagine that this flavor involves writing the new firmware to some dedicated chunk of memory, where it will be pulled either by the OS or the BIOS itself on next reboot.

    • Linus has a very good analogy here -- in fact, I love the fact that on the rare occasions I have to set modelines myself, I can pretty much put whatever I want, knowing that if it doesn't work, I can just ctrl+alt+backspace and try again.

      But the conclusion does bother me: We're basically saying that all software is buggy, or that we're incapable of preventing this kind of thing from happening (in software). This is true of most modern OS designs -- monolithic kernels do make it possible for pretty much any driver to accidentally ruin any other driver's day.

      The proposed workaround, then, is to prevent that memory from being written -- and to prevent this in hardware, for no other reason than to avoid having to write it into every kernel that might potentially allow buggy code to run in Ring 0.

      I don't like either solution. Hardware shouldn't be brickable from software, or at least, not so easily. But software shouldn't need hardware to coddle it, either -- why is the SSD in this laptop emulating a hard disk?

      • by PRMan (959735) on Saturday October 04 2008, @06:26AM (#25255195) Homepage

        Yes, because as long as the hardware can be bricked by software, it remains an exploit that can be used by malicious software writers.

        Speaking of the fried monitors, back in the day a college I worked at got a virus that fried 2 monitors before I got smart and put a Hercules monochrome card in it and cleaned it up.

        So, yes, while it can (and should) be worked around in Linux, it should also be fixed in hardware, if possible.

      • why is the SSD in this laptop emulating a hard disk?

        It's not. ATA's wire protocol uses a hardware abstraction over block storage devices, as does USB Mass Storage Class. The hard disk is emulating an ideal block device, and the SSD is also emulating an ideal block device.

        • ATA's wire protocol uses a hardware abstraction over block storage devices, as does USB Mass Storage Class. The hard disk is emulating an ideal block device, and the SSD is also emulating an ideal block device.

          This has been the case for a long time. Even with parallel IDE the drive geometry reported by the controller was typically a complete fiction. Another common feature is the ability for the drive controller to transparently remap failed blocks. Which means that by the time the host actually starts se
    • At least for consumer hardware we have come to expect that it cannot be damaged by buggy software, but in general it is not true that hardware should always protect itself against bad software. Just consider much of embedded software, e.g. the flight software for aeroplanes. Wrong software will result in "hardware damage", the same for most robots etc.

      I am quite sure that even a microprocessor driven washing machine nowadays could damage itself if the (embedded) software were buggy.

      • At least for consumer hardware we have come to expect that it cannot be damaged by buggy software, but in general it is not true that hardware should always protect itself against bad software. Just consider much of embedded software, e.g. the flight software for aeroplanes.

        Hence you'd never upgrade the firmware on all the redundant computers on an airliner at the same time. Typically with there being a minimum time (both by the calender and flying) between such upgrades.
  • Great! (Score:3, Funny)

    by silent_artichoke (973182) <silverglade00NO@SPAMgmail.com> on Friday October 03 2008, @09:27PM (#25253301) Homepage
    I'm gonna download it now! Oh, wait... crap.
  • by AaronW (33736) <aaron,slashdot013&doofus,org> on Friday October 03 2008, @09:29PM (#25253315) Homepage
    About a year ago we built up some new machines to run Linux and found that multiple e1000 cards would cause the Ethernet connectivity to drop and become useless. We ended up replacing them with much cheaper Realtek cards and all the problems disappeared. I haven't trusted Intel since. It's as if there were some buggy interrupt interaction with the on-board Intel Ethernet in the 915 chipset.
    • I had the same thing pop up on a supermicro (ICH-7, IIRC... dual Xeon 5xxx's) at work. Recompiling the modules and reinstalling them seemed to fix the problem. Like most hardware problems, it seems to be just the wrong combination of drivers, hardware, software and luck.

      I think a yum update is what triggered it, but I'm not sure; it just popped up out of nowhere and acted in such a way that I couldn't ever corner the thing. Recompiling the modules was one of those things that I did while I was thinking

    • Quite a few problems like that seem to be MSI-X related, did you try disabling them?

      • by sumdumass (711423) on Friday October 03 2008, @11:07PM (#25253727) Journal

        3com used to be that way too. I'm not exactly sure what it was but the 3c905's rocked and would run data quite a bit faster then any other card at the time. I know they had a full blown data processors on the cards but I assume the others would to. I used to go to computer shows just to pick them up for $10-$20 used because they had the same effects on data performance as you would see with rendering going from a S3 trident video adapter to a Gforce video card. I because seriously convinced when at a lan party with an AMD Athlon 800 system running windows 98se with 256 memory and we had to pull a 100 meg file from a file server to get the updates in sync to a game to play. I started pulling the file last because of helping others find it, I was on the tail end of the 3rd tire of uplinked switches and I had the file installed while others were still transering it. The funny part is that people with their brand new Windows XP 1.4 and 1.8 gig plus systems were still slower and the only thing I can attribute to it is the NIC.

        Intel caught up with 3com in this aspect and despite my older fascinations with 3com, I'm actually an Intel fan in this one respect now.

        • processors and sub systems have gotten a lot faster since then.

          i know, cheap ethernet interfaces are slower than the fastest cards out there, but your experience, from many years back when a 800 mhz cpu was fast, are a bit dated. a 100 MB file shouldn't take long enough to download from a file server even with a cheap nic unless there is a performance issue with the file server in question. 100 megabytes shouldn't take more than a few seconds to transfer across a lan.

          in theory a 100 mbit lan should take 8

          • Of course the 800 mhz system was when I First noticed that there was a difference back in 2000/2001 and things have come along faster now.

            But to reach the maximum speeds, you have to make sure you have newer equipment capable of hitting the faster speeds and that the lines are in good near perfect order to realize the maximum speeds. You also have TCP overhead that inflates the transmision size of the 100 meg file and other factors to consider like multiple users accessing the same interfaces, the amount of

  • by AcidPenguin9873 (911493) on Friday October 03 2008, @09:31PM (#25253331)

    Yes, they released a patch so that the NVM can't be overwritten after the e1000e driver is loaded. But from what I can tell, they still don't know what is/was responsible for the overwriting.

    FWIW, I'm almost positive that modern CPUs have debug traps for this exact sort of thing...you can trap arbitrary I/O writes via SMM or something...obviously I'm not in the debug loop, but I don't see why this has been so hard to figure out...

    • It makes me wonder if they have the tools available to do their job. When I did this type of work we had analyzers and ICE machines which makes it easy if you know how to use them. Are the kernel designers getting enough support to buy the needed hardware? Sometimes these things go beyond the software and can happen because of a physical condition that is untrappable in SMM, like a DMA over the top of refresh cycle fault.
        • The problem is that rather than do it the easy way with that alphabet soup of acronyms listed up there, they broke out their handy electron microscope to examine it.*

          * Yes, I'm jealous.

    • obviously I'm not in the debug loop, but I don't see why this has been so hard to figure out...

      Because it bricked the card. No way to have it fixed other than to get a replacement as there was no way reload the firmware.

      People were scared to test.

      • Re: (Score:3, Interesting)

        Which makes me hope all attempts to write to the EEPROM are being logged in the new driver, with stacktraces.

        Otherwise what's the point of testing them? Sure they won't brick your card, but you can't get very useful feedback.
    • I think it more interesting question is "how can someone overwrite".

      With that I mean "isn't there any tests around", not that Linux should (magically) become a microkernel (not that I would mind).

      • I think it more interesting question is "how can someone overwrite".

        Very easy, if the card is designed to have field-updateable firmware. You just need to send it the right (or in this case wrong) command.

        Ideally the manufacturer would make it so that you have to go through all sorts of hoops before you've done anything permanent, but this isn't the first time [theregister.co.uk] something like this has happened.

    • by SuperQ (431) * on Saturday October 04 2008, @01:58AM (#25254475) Homepage

      So the thing is, there is more than just a simple "eeprom write interface" on these chips.

      Most of the time the the eeprom attached to the nic is a cheap small serial eeprom part, usually just a few kb.. maybe 32 or 64kb. It contains mostly things like a bit of boot strapping, a few "permanent" settings like the MAC address, and the PXE rom.

      And that's where the problems come in. This serial interface is usually an afterthought, and if there is noise on that bus, bits can flip. Or if something bad happens in the NIC code, you could accidentally write when you meant to read.

      Usually this is recoverable, but I haven't looked into this specific corruption situation. I've had to deal with this kind of thing before. It's not fun.

      Flashing NIC eeproms isn't something a normal end-user does all the time. 99% of the time it's written at the factory, stuffed on the board, and forgotten about.

    • From what I can tell, the bug is only being seen on bleeding edge combinations of software in bleeding edge distros. They're thinking it's a combination of the driver and a new release of X (one allows for the conditions, the other glitches after that), but there's very little 'tried-and-true' stuff in a bleeding edge distro.
  • From RTFA the cause of the problem has not been identified yet, however the problem is prevented from being able to present itself going forward by maliciously writing/erasing non volatile memory. Since the problem was caught at alpha/beta stages the stable releases were unaffected. BTW, My boss tried to RTFA over my shoulder and shot cheese out of his ears (he is the non techie type). Its threads like these that absolutely cement /.'s place as the worlds dominant UBER NERD site.
    • My boss tried to RTFA over my shoulder and shot cheese out of his ears

      Can he do that on demand?

    • Just buy a copy of Windows and get on with it.

      You may have missed the part where it said that this is a development release. Also, installing a development release of the next Windows might brick your system AND get you sued. ;-)

      • If there's a whoosh, I don't get it either, other than that it has to be...

        I don't think Intel makes solid state drives. Nor does Intel make the EEE PC. Nor does any EEE PC ship with an experimental kernel. Nor does an ethernet card have anything to do with a hard drive.

        Some quick Googling shows that the 901 may have gigabit, maybe not -- and if it did, and if they were this particular Intel card, you might be affected. Which would still have nothing to do with the SSD.

        But after checking the manuals I could